[PATCH] bsps/arm: replace CMSIS v4 with CMSIS v5 files

[Karel Gardas]

On 7/14/23 01:24, Joel Sherrill wrote:
> On Thu, Jul 13, 2023 at 4:11 PM Karel Gardas <karel at functional.vision> 
> wrote:
> 
> 
>        Folks,
> 
>     please take this patch as an attempt to renew old discussion or rather
>     start a new one focused solely on importing new ARM CMSIS code which is
>     (i) under Apache 2 license but (ii) without any NOTICE file.
> 
> 
> The absence of a NOTICE file is OK. If they had one, we would just have
> to pass it along.
> 
> I recall the issue is that "You must cause any modified files to carry 
> prominent
> notices stating that You changed the files"
> 

OK, but this is even easier since I have not modified files at all. They 
are just verbatim copy.

> My reading is that we would need to pass the NOTICE file along. I personally
> do not see that as a burden unless it contains more than credit or 
> permissively
> license info.

OK! I think decision process itself of "unless it contains more than..." 
may be seen as a burden. But, fortunately no NOTICE file there, hence no 
issue...

>     The patch itself is clear replace of existing files with a new files,
>     plus required files added and old one not needed anymore removed.
> 
>     The patch was very lightly tested by building several ARM BSPs
>     especially those affected by the change.
> 
> 
> Did you have any BSPs to actually test on? What ones can be tested
> for this?

Yes, I can run testsuite on 2 boards I have sitting idle here: 
stm32h747i-disco and stm32h7b3i-dk where 747 would test both M7 and M4 
variants. By comparing results from current tree and current tree + 
patch we may see any unexpected breakage...

>     Thanks for any comments!
> 
> 
> I'm happy with the update and think it is OK license wise. Technically, 
> it you
> trust it, I'm ok with it.

Cool! Thanks,

Karel