[PATCH v1 2/2] bsps/stm32h7: Configure UART clocks when enabled

[Karel Gardas]

On 7/24/23 23:17, Kinsey Moore wrote:

[...]

>     There is no other UART1 connector provided on the board. So I do not
>     see
>     reason why you add all other UARTs into #ifdefs for this particular
>     board/bsp variant? And hence my question about your motivation and
>     where
>     you are heading...
> 
> 
> Given that, I now understand the confusion. I have a board in hand that 
> will never see an upstream BSP and I was hoping to be able to configure 
> the base STM32H7 BSP for it, but what I interpreted as the "base" 
> STM32H7 BSP is not actually a generic base BSP. I was also contemplating 
> moving more of the peripheral configuration into shared files since the 
> enable/disable configuration items are already there and it would be 
> convenient for the various BSPs to exist as some custom code and then a 
> selection of presets for those configuration items. I'll have to think 
> about the best way forward for the project I'm working with.

I guess the philosophy in stm32h7 is to avoid cpp directives even in 
case of a bit more code duplication.

So if I may ask, just copy board directory structure, name it after your 
board and tweak the copied files there. No need to #ifdefing in 
different board which would not use that.

And btw, I'm using the same for Precidata SL-3011 (board on market, but 
BSP and firmware not ready for RTEMS 6, will be submitted for RTEMS 7 
probably) and for Arduino Portenta H7 (ditto but even less mature codewise).

Thanks!
Karel