[PATCH] improved error checking in ticks per timeslice

Gedare Bloom gedare at rtems.org
Tue Feb 20 21:10:30 UTC 2024


On Sun, Feb 18, 2024 at 3:31 PM Chris Johns <chrisj at rtems.org> wrote:
>
> On 18/2/2024 4:42 am, Gedare Bloom wrote:
> > Is there a simple way we can add some checks for modification of
> > generated files into a commit hook? And then, point to a documentation
> > that helps explain where to go for more guidance depending on the code
> > generation source?
>
> We are moving to GitLab so I think avoiding git hooks is something we should
> avoid at this point in time. And there are security issues with them. Could a
> stage in a CI pipeline handle this? The PR would fail.
>
OK

> > I would use this for all rtems-central generated stuff, and also for
> > 3rd party sources where there's an active upstream. I can add such a
> > plan to follow #4663 Third-Party Sources Manifest
>
> You would need to find a way to add these files to the repo. Separating the
> mapping from the repo would create an external dependency I would prefer we do
> not have.
>

I'm not sure I followed your point here. I simply meant that any
existing files in rtems.git that are generated (or imported) from
elsewhere should be tracked and should not be accidentally modified by
directly writing them.

> Chris


More information about the devel mailing list