[Bug 1876] Add SMP ISR support

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Tue Aug 9 19:57:25 UTC 2011


https://www.rtems.org/bugzilla/show_bug.cgi?id=1876

Marta Rybczynska <marta.rybczynska at kalray.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marta.rybczynska at kalray.eu

--- Comment #6 from Marta Rybczynska <marta.rybczynska at kalray.eu> 2011-08-09 14:57:24 CDT ---
Generally it is a move in the right direction. I have some notes:

1. The exact usage of _ISR_SMP_Enter and friends. Where in the interrupt entry
sequence it will be exactly? (I guess the BSP code would make it all clear).

2. Wouldn't it be better to first split the meaning of ISR_Disable to local ISR
disable + lock ? I guess it is heading this way. At this point I remind about
#1809 . Full sequence includes one more patch + some locking corrections, not
too long to be extracted if needed.

3. Question of style. The lock debugging functions could have names that state
more clearly that they are to be used just for debug and they are not a part of
the normal program flow. Some "_Debug_" prefix, for instance (at first read,
the changes that included those functions were unclear because of this).

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list