[Bug 1876] Add SMP ISR support

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1876

--- Comment #7 from Jennifer Averett <jennifer.averett at oarcorp.com> 2011-08-22 12:22:15 CDT ---
> Generally it is a move in the right direction. I have some notes:
>
> 1. The exact usage of _ISR_SMP_Enter and friends. Where in the interrupt entry
> sequence it will be exactly? (I guess the BSP code would make it all clear).

This is the isr entry point in the bsp which I think are assembly file sparc
and i386.

> 2. Wouldn't it be better to first split the meaning of ISR_Disable to local
> ISR disable + lock ? I guess it is heading this way. At this point I remind
> about #1809 . Full sequence includes one more patch + some locking 
> corrections, not too long to be extracted if needed.

I believe you have already spoken to Joel on this one.

> 3. Question of style. The lock debugging functions could have names that state
> more clearly that they are to be used just for debug and they are not a part > of the normal program flow. Some "_Debug_" prefix, for instance (at first 
> read, the changes that included those functions were unclear because of this).

I will change these names to have Debug in the name.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.