[Bug 1993] Mips conversion to PIC IRQ model

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1993

Gedare <gedare at rtems.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gedare at rtems.org

--- Comment #1 from Gedare <gedare at rtems.org> 2011-12-15 12:52:23 CST ---
I'm not familiar with the MIPS bsps but I do have some comments.

c/src/lib/libbsp/mips/jmr3904/include/irq.h:
+  #define TX3904_IRQ_SOFTWARE_2  MIPS_INTERRUPT_BASE+18
+  #define TX3904_MAXIMUM_VECTORS MIPS_INTERRUPT_BASE+19
+
+#define BSP_INTERRUPT_VECTOR_MAX TX3904_MAXIMUM_VECTORS
+
+#define JMR3904_IRQ_PRIORITY_VALUE_MIN 0
+#define JMR3904_IRQ_PRIORITY_VALUE_MAX 15    /* XXX - How is this determined?
*/
Any reason some of these are TX3904 and some are JMR3904?

c/src/lib/libbsp/mips/jmr3904/include/irq.h:
+  #define TX3904_IRQ_INT1        MIPS_INTERRUPT_BASE+0
+  #define TX3904_IRQ_INT2        MIPS_INTERRUPT_BASE+1
+  #define TX3904_IRQ_INT3        MIPS_INTERRUPT_BASE+2
...
c/src/lib/libbsp/mips/jmr3904/include/tx3904.h:
+#define TX3904_IRQ_INT1        MIPS_INTERRUPT_BASE+0
+#define TX3904_IRQ_INT2        MIPS_INTERRUPT_BASE+1
...
All of these should have parenthesis to protect them. Also why are some of the
same macros being defined in both files?

+#define JMR3904_IRQ_PRIORITY_COUNT (LPC24XX_IRQ_PRIORITY_VALUE_MAX + 1)
+#define JMR3904_IRQ_PRIORITY_HIGHEST LPC24XX_IRQ_PRIORITY_VALUE_MIN
+#define JMR3904_IRQ_PRIORITY_LOWEST LPC24XX_IRQ_PRIORITY_VALUE_MAX

this looks wrongs. maybe someone forgot a /g in their find/replace :)

c/src/lib/libbsp/mips/shared/irq/irq.c:
+
+rtems_status_code bsp_interrupt_vector_enable(rtems_vector_number vector)
+{
+  return RTEMS_SUCCESSFUL;
+}
+
+rtems_status_code bsp_interrupt_vector_disable(rtems_vector_number vector)
+{
+  return RTEMS_SUCCESSFUL;
+}
Are these supposed to do anything / are they used at all?

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.