[Bug 1962] Problems with MVME162 BSP

[bugzilla-daemon at rtems.org]

https://www.rtems.org/bugzilla/show_bug.cgi?id=1962

--- Comment #4 from Gedare <gedare at rtems.org> 2011-11-10 20:30:56 CST ---
(In reply to comment #3)
> Thanks for filing this PR! One note, usually we prefer patches with the -u flag
> (they are a little easier to read).
> 
> I also have a minor suggestion that I think could make the code a little easier
> to maintain. You might change the define in mvme162/include/bsp.h to be
> something like:
> #if defined(mvme162lx)
> #define 162BUG_VEC_ADDRESS 0x00000000
> #else
> #define 162BUG_VEC_ADDRESS 0xFFE00000
> #endif
> 
> Then the following
> ! #if defined(mvme162lx)
> !   m68k_set_vbr(0x00000000);         /* restore 162Bug vectors */
> ! #else
> !   m68k_set_vbr(0xFFE00000);         /* restore 162Bug vectors */
> ! #endif
> 
> And
> 
> ! #if defined(mvme162lx)
> !   monitors_vector_table = (m68k_isr_entry *)0x00000000;
> ! #else
> !   monitors_vector_table = (m68k_isr_entry *)0xFFE00000;
> ! #endif
> 
> become
> 
>   m68k_set_vbr(162BUG_VEC_ADDRESS);
> ...
>   monitors_vector_table = (m68k_isr_entry *)162BUG_VEC_ADDRESS;
> 
> these should work and reduce the number of places that would need to be updated
> if the SRAM or DRAM base addresses changed.

Oops! That is exactly what you did! :) I just didn't quite parse the patch
right.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.