[Bug 1910] An option for architecture-specific SMP locks

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Wed Aug 8 15:15:55 UTC 2012


--- Comment #15 from Joel Sherrill <joel.sherrill at oarcorp.com> 2012-08-08 10:15:55 CDT ---
(In reply to comment #14)
> This looks fine to me.

I am OK with this patch with two concerns:

+ why unsigned int instead of the uint32_t? 
  I think you are staying close to "register" size types.

+ _CPU_cache_flush_1_data_line is a macro implemented in libcpu. It is not
available at the point in cpukit where smplock is compiled. It is also 
not defined for all architectures. 

This patch seems very simple if we can agree on what to do with
_CPU_cache_flush_1_data_line. Without knowing the CPU model, you can't reliably
depend on knowing how to do that.

Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

More information about the bugs mailing list