[Bug 1910] An option for architecture-specific SMP locks

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Wed Aug 8 15:25:04 UTC 2012


--- Comment #16 from Gedare <gedare at rtems.org> 2012-08-08 10:25:04 CDT ---
(In reply to comment #15)
> (In reply to comment #14)
> > This looks fine to me.
> I am OK with this patch with two concerns:
> + why unsigned int instead of the uint32_t? 
>   I think you are staying close to "register" size types.
Sebastian suggested using int. Yes the point is to stay closer to the natural
word size.

> + _CPU_cache_flush_1_data_line is a macro implemented in libcpu. It is not
> available at the point in cpukit where smplock is compiled. It is also 
> not defined for all architectures. 
> This patch seems very simple if we can agree on what to do with
> _CPU_cache_flush_1_data_line. Without knowing the CPU model, you can't reliably
> depend on knowing how to do that.
How about using rtems_cache_flush_multiple_data_lines(addr, num)? num=1 should
result in flushing 1 line I would think. Of course this still requires that the
architecture implement the function, but for those that do not it should just
be an nop anyways.

Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

More information about the bugs mailing list