[Bug 2185] New: Enhance rtems_termios_puts to write more than one char at once

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Thu Aug 7 11:53:54 UTC 2014


https://www.rtems.org/bugzilla/show_bug.cgi?id=2185

             Bug #: 2185
           Summary: Enhance rtems_termios_puts to write more than one char
                    at once
    Classification: Unclassified
           Product: RTEMS
           Version: HEAD
          Platform: All
        OS/Version: RTEMS
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: cpukit
        AssignedTo: joel.sherrill at oarcorp.com
        ReportedBy: rtemsdev at ixo.de


Created attachment 1568
  --> https://www.rtems.org/bugzilla/attachment.cgi?id=1568
Patch for termios.c as described

The rtems_termios_puts(), as is, calls (*tty->handler.write)() once per char. 

To minimize overhead e.g. with DMA setup in driver, it could send more at once. 

The attached patch implements a quite simple loop for copying more than one
char before calling (*tty->handler.write)().

Note that it does *not* enable interrupts while copying as suggested by the
comment in the original source code. 

The amount of chars copied however is guaranteed to be less than rawOutBuf
size.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list