[Bug 2185] Enhance rtems_termios_puts to write more than one char at once

bugzilla-daemon at rtems.org bugzilla-daemon at rtems.org
Thu Aug 7 12:43:56 UTC 2014


https://www.rtems.org/bugzilla/show_bug.cgi?id=2185

Sebastian Huber <sebastian.huber at embedded-brains.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebastian.huber at embedded-br
                   |                            |ains.de

--- Comment #1 from Sebastian Huber <sebastian.huber at embedded-brains.de> 2014-08-07 07:43:56 CDT ---
It is easier if you send patches to the devel at rtems.org list.

In general such a change looks all right, but we have to make sure that
existing drivers don't get confused.  The integer types should fit, e.g.
partlen should be size_t.  Declarations should be at the block begin, for the
coding style please have a look at

http://www.rtems.org/wiki/index.php/Coding_Conventions

I would avoid the multiple modulo operations since they may be really expensive
on some targets.

-- 
Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the bugs mailing list