RTEMS | ftpd.c: Do not use negative socket descriptor (!173)

Joel Sherrill (@joel) gitlab at rtems.org
Thu Aug 8 23:33:24 UTC 2024




Joel Sherrill commented on a discussion on cpukit/ftpd/ftpd.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/173#note_110759

 >    struct timeval tv;
 >    int len = sizeof(tv);
 >  
 > +  if(s < 0)

If I add a comment, Coverity will still think it is an issue. And I have to do a commit, cynically it is about the same work as adding the if. I can add a comment if you like but the if probably should stay.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/173#note_110759
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240808/757e3ad1/attachment.htm>


More information about the bugs mailing list