RTEMS | ftpd.c: Do not use negative socket descriptor (!173)

Amar Takhar (@amar) gitlab at rtems.org
Thu Aug 8 23:49:27 UTC 2024




Amar Takhar commented on a discussion on cpukit/ftpd/ftpd.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/173#note_110760

 >    struct timeval tv;
 >    int len = sizeof(tv);
 >  
 > +  if(s < 0)

No I mean keeping the code but adding a comment that it was added due to a Coverity highlight about -1 possibly being passed in.  To me at least it seems like an out of place check I'd want to know why it's there.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/173#note_110760
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240808/d9ba7ca5/attachment-0001.htm>


More information about the bugs mailing list