RTEMS | msdos: update inode during rename (!80)

Joel Sherrill (@joel) gitlab at rtems.org
Mon Jul 1 22:27:21 UTC 2024




Joel Sherrill commented on a discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_108565


That's a long list of challenges. Let's see if we can narrow them down. Sorry this changes the order but hopefully this is easy to follow. 

These are probably just a matter of changing the error return code that is used by dosfs and should be one line changes:

- Rename file with directory fails (wrong errno)
- Rename directory with file fails (wrong errno)
- Rename directory with ancestor directory fails (wrong errno)
- Testing empty filepath fails (wrong errno)

The following test cases should be split out to a separate executable or moved if there is another test where they could go that is already not run on the dosfs. Somehow they just get included in an executable that makes sense.

- Symlinks tests fail, but this is expected because FAT does not handle them
- The tests that deal with permissions (I guess also these are expected failures)

That leaves these which "feel" harder to fix.

- Rename same file fails
- Rename empty directory with another empty directory fails

If you can address the first two groups which seems manageable, that leaves the two last rename ones. Any idea what these two need to be checking for? It just seems like these are missing a check. 

Disclaimer: I haven't worked on the dosfs.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_108565
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20240701/e93fbefe/attachment.htm>


More information about the bugs mailing list