RTEMS | Add the support for i2c driver in the aarch64/raspberrypi bsp (!363)

Kinsey Moore (@opticron) gitlab at rtems.org
Sat Apr 26 18:59:12 UTC 2025




Kinsey Moore started a new discussion on bsps/aarch64/raspberrypi/i2c/raspberrypi-i2c.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_122274

 > +{
 > +  raspberrypi_i2c_bus *bus = (raspberrypi_i2c_bus *) base;
 > +  int                  rv  = 0;
 > +  uint32_t             i;
 > +  uint8_t              msbs;
 > +
 > +  for ( i = 0; i < msg_count; ++i ) {
 > +    if ( msgs[ i ].flags & I2C_M_RECV_LEN ) {
 > +      return RTEMS_INVALID_NUMBER;
 > +    }
 > +  }
 > +
 > +  for ( i = 0; i < msg_count; i++ ) {
 > +    bus->current_buffer      = msgs[ i ].buf;
 > +    bus->current_buffer_size = msgs[ i ].len;
 > +    bus->remaining_transfers = ( bus->current_buffer_size + 0xFFFFE ) / 0xFFFFF;

More magic numbers that should probably have descriptive labels.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/363#note_122274
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250426/7a722d26/attachment-0001.htm>


More information about the bugs mailing list