RTEMS | Draft: cpukit/shell: Honor the forever flag (!371)

[Chris Johns (@chris)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/371 was reviewed by Chris Johns

--
  
Chris Johns commented on a discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/371#note_127191


Please check https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/619 and what I found here. Termios will block and stay blocked in the reader with the shell termios settings we have. I found there is little you can without With this change you can alter the telnet pty code with something like:

```cpp
void wake_console() {
    struct termios term;
    if (tcgetattr(console_fd, &term) == 0) {
        term.c_cc[VMIN] = 0;
        term.c_cc[VTIME] = 0;
        if (tcsetattr(console_fd, TCSANOW, &term) != 0) {
            std::cout << "shell: wake-console: stdin: cannot set cterm"
                      << std::endl;
        }
    } else {
        std::cout << "shell: wake-console: stdin: cannot get cterm"
                  << std::endl;
    }
}
```

I have have this code when rebooting from a websocket shell session.

I think this change breaks the shell functionality.


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/371
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250724/0897ba33/attachment.htm>