RTEMS | Add AArch64 Xen support and dependencies (!535)

Joel Sherrill (@joel) gitlab at rtems.org
Wed Jun 25 22:49:32 UTC 2025



Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/535 was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on bsps/aarch64/shared/start/start.S: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/535#note_125369

 >    .section ".bsp_start_text", "ax"
 >  
 > +#ifdef BSP_START_IMAGE_HEADER

What format is this header? Comment with URL possibly?

--
  
Joel Sherrill started a new discussion on cpukit/score/cpu/aarch64/aarch64-exception-default.S: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/535#note_125370

 >   * Branch and link to the address in x0. There is no reason to save the current
 > - * LR since it has already been saved and the current contents are junk.
 > + * LR since it has already been saved.

I thought comments in asm started over the code when inline to instructions. Clearly that's not how this file was formatted.

@gedare  Could we get a style ruling here? Do the inline comments start over the instruction or the left hand margin?


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/535
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20250625/057347f1/attachment.htm>


More information about the bugs mailing list