RTEMS | libi2c: Use RTEMS thread API and support initialization at device driver level (!821)

[Gedare Bloom (@gedare)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/821 was reviewed by Gedare Bloom

--
  
Gedare Bloom started a new discussion on bsps/powerpc/mvme3100/i2c/i2c_init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/821#note_135704

 > +	/* Library initialize by io module */
 >  
 >  	/* Register our bus driver */

This comment looks like it's in the wrong place now.

--
  
Gedare Bloom started a new discussion on bsps/powerpc/mvme3100/i2c/i2c_init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/821#note_135705

 > +        return -1;
 > +    }
 > +

is there mixed tabs and spaces? feel free to fix the style of this file.

--
  
Gedare Bloom started a new discussion on cpukit/libi2c/libi2c.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/821#note_135706

 > -    is_initialized = false;
 > +    rtems_mutex_destroy(&libmutex);
 > +    rtems_libi2c_is_initialized = false;

Since this (global) variable is being modified multiple times, is there a possible race condition?


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/821
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20251105/48dc8170/attachment-0001.htm>