RTEMS | libfs/pipe: Add pipe and pipe2 indirect handler calls (!1383)

[Joel Sherrill (@joel)]

Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383 was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on cpukit/include/rtems/libio.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383#note_156402

 > +/**@{**/
 > +
 > +/**

Comments as to use case and not intended for applications.

Perhaps even putting this behind some ifdef so only the intended users see it.

--
  
Joel Sherrill started a new discussion on cpukit/include/rtems/libio.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383#note_156403

 > + * @param[in] pipe_handler Handler to called when `pipe()` is called.
 > + */
 > +void rtems_filesystem_register_pipe( rtems_pipe_handler_t pipe_handler);

Mismatched spacing in ().

--
  
Joel Sherrill started a new discussion on cpukit/include/rtems/libio.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383#note_156404

 > + * @param[in] pipe2_handler Handler to called when `pipe2()` is called.
 > + */
 > +void rtems_filesystem_register_pipe2( rtems_pipe2_handler_t pipe2_handler);

Mismatched spacing in ().

--
  
Joel Sherrill started a new discussion on cpukit/libfs/src/pipe/pipe.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383#note_156405

 > +static rtems_pipe2_handler_t pipe2_handler = pipe2_default;
 > +
 > +void rtems_filesystem_register_pipe( rtems_pipe_handler_t pipe_handler_ )

The trailing underscore is unusual. How about anything else? I'd be happy with something as simple as "pipe_handler_arg" or even "pipe_handler_impl". Just anything beyond a trailing _.

--
  
Joel Sherrill started a new discussion on cpukit/libfs/src/pipe/pipe.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383#note_156406

 > +}
 > +
 > +void rtems_filesystem_register_pipe2( rtems_pipe2_handler_t pipe2_handler_ )

The trailing underscore is unusual. How about anything else? I'd be happy with something as simple as "pipe_handler_arg" or even "pipe_handler_impl". Just anything beyond a trailing _.

--
  
Joel Sherrill started a new discussion on testsuites/psxtests/psxpipe01/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383#note_156407

 > +
 > +  puts( "" );
 > +  puts( "Pipe handler tests:" );

No scn or doc file updates


-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383
You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-9dmi3spfga0qen3x8vf21xwgm-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260803/34b16cc5/attachment-0001.htm>