RTEMS | libfs/pipe: Add pipe and pipe2 indirect handler calls (!1383)
Chris Johns (@chris)
gitlab at rtems.org
Mon Aug 3 22:06:11 UTC 2026
Chris Johns commented on a discussion on cpukit/libfs/src/pipe/pipe.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383#note_156417
> }
> return 0;
> }
> +
> +static int pipe2_default( int fildes[ 2 ], int flags )
> +{
> + (void) fildes;
> + (void) flags;
> + errno = ENXIO;
> + return -1;
> +}
> +
> +static rtems_pipe_handler_t pipe_handler = pipe_default;
> +static rtems_pipe2_handler_t pipe2_handler = pipe2_default;
> +
> +void rtems_filesystem_register_pipe( rtems_pipe_handler_t pipe_handler_ )
I am not in favor of using type of based adjectives in names such as `_arg`. If we start this then I would like us to head fully down the path and add the type, position and more to point we encode it into a short hand form so no one understands it :stuck_out_tongue_winking_eye:
The tailing `_` is something I use in C++ a lot as a simple pattern to deal with shadowed variables that scales on large code bases. It is clear the variable, argument or whatever is a shadow of an instance variable or in this case a global. I will change it.
--
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1383#note_156417
You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-3thb1wlhl5nhiyzq4bng6aeu1-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260803/7aaad900/attachment-0001.htm>
More information about the bugs
mailing list