RTEMS | bsp/arm/tms570: unlock IOMM and disable interrupts before setting pins (!1218)

[Pavel Pisa (@ppisa)]

Pavel Pisa commented: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1218#note_155071


@thnkslprpt Excuse me for slow responses. I am happy that you work on the TMS570 but my time is a problem.

As for this case, I accept/agree that `tms570_bsp_pin_set_function` and `tms570_bsp_pin_clear_function` other these functions are exported in the flavor with pinmux unlocking and interrupts disable but the original functions without pinmux unlocking and interrupt disable should be preserved under some name like `tms570_bsp_pin_set_function_base`, `_bare`, '_raw', '_unlocked'. The wrapper functions should disable interrupts, enable pinmux updates and then call '_unlocked' functions version.

I am open to discussion, but I see  this as the reasonable choice which allows both uses, strict separation where in the code pinmux manipulation is enabled, and or have it on hand as needed. When function sections are used during linking then even functions variant combining unlock and manipulation would not appear in the final image when strict separation is preferred.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1218#note_155071
You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-409cox3jana81krddh68q8b8f-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260722/c550e695/attachment.htm>