RTEMS | bsp/arm/tms570: Remove misnamed/stale alias TMS570_MMR_SELECT_GMII_SEL (!1271)

[Pavel Pisa (@ppisa)]

Pavel Pisa commented on a discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1271#note_155431


My idea and preference is to implement Launchpad option, extend pins "database" and add Launchpad version of the default pin list the first and then use this as base for LwIP. By the way, it would be ideal to build core pinlist from fragments, because then fragment specific to MII can be used in TMS570 LwIP and LwIP code do not need to know anything ale about specific board setup.

Even `TMS570_MMR_SELECT_MII_SEL`, `PHY_PWRDOWN_PIN`, `PHY_RESET_PIN` and clock pin could be provided by board selection in BSP build and LwIP code can only check if they are defined and use them.

In the longer term, it would worth to keep only SoC pin "database" in `arm/tms570/include/bsp/tms570lc4357-pins.h` and `arm/tms570/include/bsp/tms570ls3137zwt-pins.h`, and move HDKs and lauchpad specific default list and peripherals fragments to something like `bsps/arm/tms570/include/bsp/tms570lc4357-pins-hdk.h`, `bsps/arm/tms570/include/bsp/tms570lc4357-pins-lchxl2.h`, and `bsps/arm/tms570/include/bsp/tms570ls3137zwt-pins-hdk.h`. Then `bsps/arm/tms570/include/bsp/tms570-pins.h` can decide according to the config options which SoC "database" to select and which board file to use to combine defaults.

Then if the `tms570_pinmmr_init_data` global variable is move to separate file which results in separate object in the RTEMS library archive then it can be easily overridden when custom version of  `tms570_pinmmr_init_data` is provided by application build against RTEMS TMS570 install which can prepare list specific to given board routing or alternatives selections as they are on HDK even supported by jumpers etc.

So this is long term plan.

The common functions for GPIO pins direction, read and state control should be provided as well. MMR position does not somehow directly correspond to the GPIO port and pin number so there so it is not possible to use pins defined for MMR in GPIO code. So fo these pins used for some specific there has to be something like `TMS570_MMR_SELECT_MII_SEL` and `TMS570_GPIO_PIN_MII_SEL` which would combine port number and pin bit position...

All these has been plans from BSP introduction waiting to time when somebody has real use for chip with RTEMS and time/resources to advance from HalCoGen generated init to something more maintainable and self documented.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1271#note_155431
You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-86kltycb6iso0h58kzfmr1pzb-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260725/d41ce37f/attachment-0001.htm>