RTEMS | Complete the u-boot support for qoriq BSP (!1046)

Tue Mar 3 00:46:02 UTC 2026

Sebastian Huber commented on a discussion on bsps/powerpc/qoriq/start/uboot_support.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1046#note_144118

 > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
 > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
 > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
 > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
 > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
 > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 > + * POSSIBILITY OF SUCH DAMAGE.
 > + */
 > +
 > +#include <stdint.h>
 > +
 > +#include <bsp.h>
 > +
 > +#if defined(HAS_UBOOT)

The HAS_UBOOT option itself is fine, but I think using it in uboot_getenv.c() is unnecessary. You can always provide this implementation for the BSPs using it. If the environment size is zero (defined by some new BSP option), the bsp_uboot_getenv() should simply always return NULL.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1046#note_144118
You're receiving this email because of your account on gitlab.rtems.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260303/0d3f9728/attachment.htm>