RTEMS | cpukit/include/rtems/score: FIXME (!1082)

[Samuel Viegas (@samuel.viegas)]

Samuel Viegas commented on a discussion on cpukit/include/rtems/score/tls.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1082#note_150700

 >  
 >  typedef struct {
 >    /*
 > -   * FIXME: Not sure if the generation number type is correct for all

I didn't just remove the FIXME, I modified the comment and the variable "generation_number" type and the commit message also provides some context. I think this change addresses the concern (the fact that the uint32_t might not be the right width on all architectures) because, by changing uint32_t to uintptr_t exactly matches the native word size on every supported architecture, 32-bit on 32-bit targets and 64-bit on 64-bit targets. Additionally, the "generation_number" field is only ever used once and just assigned the literal value 1, so there is no overflow concern regardless of width. I will try to improve the commit message to better explain the change. I will wait for your feedback on this.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1082#note_150700
You're receiving this email because of your account on gitlab.rtems.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/bugs/attachments/20260521/d407a102/attachment-0001.htm>