[PATCH 3/4] libblock: Change error status to fatal error

Chris Johns chrisj at rtems.org
Thu Apr 12 02:52:59 UTC 2012


On 29/03/12 12:30 AM, sebastian.huber at embedded-brains.de wrote:
> From: Sebastian Huber<sebastian.huber at embedded-brains.de>
>
> Calling the bdbuf API functions in the not configured state is now a
> fatal error.

Moving to a fatal error is fine. I just wonder if a lock not being 
obtained is a little abstract and a more concrete fatal error should be 
added. The user is left to wonder if they have enough mutex resources or 
there is a failure to correctly create the mutex rather than the simpler 
problem of not calling the init routine. This could be based on the 
result code and not another test in the locking path.

Chris



More information about the devel mailing list