[PATCH 33.0 1/5] LEON: updated AMBA PnP API

Ralf Corsepius ralf.corsepius at rtems.org
Mon Apr 16 13:01:49 UTC 2012


On 04/16/2012 02:33 PM, Sebastian Huber wrote:
> On 04/16/2012 10:23 AM, Daniel Hellstrom wrote:
>>> Second is the indentation. We usually use 2 spaces per indent level
>>> while this code uses 6 or so.
>> Yes, it have hard TAB = 8 spaces. I believe I have asked before about
>> indentation, and I've got the impression that it doesn't really matter
>> as it is
>> consistent within the file. At least it is easier to go from hw-tab to
>> soft,
>> and of course I agree that all files should aim to have the same
>> coding-style.
>> I will update the patches and come back.
>
> Maybe it makes sense to define a set of astyle
>
> http://astyle.sourceforge.net/

Why are you proposing this tool?

It's far from being standard or widely adopted. The standard tool to 
enforce a coding style would be indent.

Ralf



More information about the devel mailing list