[PATCH 33.0 1/5] LEON: updated AMBA PnP API

[Sebastian Huber]

On 04/16/2012 03:01 PM, Ralf Corsepius wrote:
 > On 04/16/2012 02:33 PM, Sebastian Huber wrote:
 >> On 04/16/2012 10:23 AM, Daniel Hellstrom wrote:
 >>>> Second is the indentation. We usually use 2 spaces per indent level
 >>>> while this code uses 6 or so.
 >>> Yes, it have hard TAB = 8 spaces. I believe I have asked before about
 >>> indentation, and I've got the impression that it doesn't really matter
 >>> as it is
 >>> consistent within the file. At least it is easier to go from hw-tab to
 >>> soft,
 >>> and of course I agree that all files should aim to have the same
 >>> coding-style.
 >>> I will update the patches and come back.
 >>
 >> Maybe it makes sense to define a set of astyle
 >>
 >> http://astyle.sourceforge.net/
 >
 > Why are you proposing this tool?

It was mentioned recently on the GCC mailing list and looks good (I only looked 
briefly at the documentation).

 > It's far from being standard or widely adopted. The standard tool to enforce a
 > coding style would be indent.

I never was happy with the output.

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.