[rtems commit] bsp/mpc55xx: Set PPC_EXC_CONFIG_USE_FIXED_HANDLER

[Sebastian Huber]

On 12/03/2012 05:51 PM, Sebastian Huber wrote:
> On 12/03/2012 02:38 PM, Ralf Corsepius wrote:
>> On 12/03/2012 01:14 PM, Sebastian Huber wrote:
>>> Module:    rtems
>>> Branch:    master
>>> Commit:    3ce66aabb5be97ee0bd216f735e224c317d9667e
>>> Changeset:
>>> http://git.rtems.org/rtems/commit/?id=3ce66aabb5be97ee0bd216f735e224c317d9667e
>>>
>>> Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
>>> Date:      Mon Nov 19 09:02:12 2012 +0100
>>>
>>> bsp/mpc55xx: Set PPC_EXC_CONFIG_USE_FIXED_HANDLER
>>>
>>> ---
>>>
>>>   c/src/lib/libbsp/powerpc/mpc55xxevb/Makefile.am    |    1 +
>>>   c/src/lib/libbsp/powerpc/mpc55xxevb/configure.ac   |    4 ++
>>>   .../libbsp/powerpc/mpc55xxevb/startup/bspstart.c   |    4 ++-
>>>   .../powerpc/mpc55xxevb/startup/exc-vector-base.S   |   18 +++++++++
>>>   c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c         |   39
>>> +++++++++++++++-----
>>>   5 files changed, 55 insertions(+), 11 deletions(-)
>>
>>> diff --git a/c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c
>>> b/c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c
>>> index c60a301..024ea80 100644
>>> --- a/c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c
>>> +++ b/c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c
>>> @@ -7,12 +7,13 @@
>>>    */
>>>
>>>   /*
>>> - * Copyright (c) 2008
>>> - * Embedded Brains GmbH
>>> - * Obere Lagerstr. 30
>>> - * D-82178 Puchheim
>>> - * Germany
>>> - * rtems at embedded-brains.de
>>> + * Copyright (c) 2008-2012 embedded brains GmbH.  All rights reserved.
>>> + *
>>> + *  embedded brains GmbH
>>> + *  Obere Lagerstr. 30
>>> + *  82178 Puchheim
>>> + *  Germany
>>> + * <rtems at embedded-brains.de>
>>
>> Please be more careful about copyright disclaimers.
>>
>> Your "2008"->"2008-2012" change above implies you to have applied copyrightable
>> material all consecutive years 2008 through 2012.
>>
>> Without having checked the sources and pushing aside considerations on whether
>> your changes actually are copyrighable, I am having doubts, this applies.
>>
>> I believe you actually want to change the copyright disclaimer from
>> "2008" into "2008, 2012", denoting you applied major changes to your works from
>> 2008 in 2012.
>
> Thanks for the hint.  I will have a look at this.

Feel free to start a discussion on the mailing list about this topic since this 
problem exists in several files inside of RTEMS.  For the moment we will leave 
it as is.

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.