[Bug 2030] New: Export more shell functions

[Chris Johns]

On 26/02/12 5:46 AM, Joel Sherrill wrote:
> On my phone without code access but I think all shell command entry points can be static but the structure that is used by shellconfig.h must not be static.

Why do they need to be static ?

I can see cases where a user might dup stdout run the command and 
capture the output. I know Alan does this in the MMS project.

I think we should keep the shell helper functions available and public. 
If we are missing decls for the functions we should add them.

>
> Shell helper methods like make args and others to invoke a script or initialize the shell must be public.
>
> The exception would be a case where you might invoke a shell commands main method directly and I don't know of these.
> Or where one command wraps or uses another.
>
> --joel
>
> Gedare Bloom<gedare at rtems.org>  wrote:
>
>> Ralf,
>> On Fri, Feb 24, 2012 at 4:36 PM,<bugzilla-daemon at rtems.org>  wrote:
>>> https://www.rtems.org/bugzilla/show_bug.cgi?id=2030
>>>
>>>              Bug #: 2030
>>>            Summary: Export more shell functions
>>>     Classification: Unclassified
>>>            Product: RTEMS
>>>            Version: HEAD
>>>           Platform: All
>>>         OS/Version: RTEMS
>>>             Status: NEW
>>>           Severity: normal
>>>           Priority: P3
>>>          Component: cpukit
>>>         AssignedTo: joel.sherrill at oarcorp.com
>>>         ReportedBy: sebastien at milkymist.org
>>>
>>>
>>> Created attachment 1445
>>>   -->  https://www.rtems.org/bugzilla/attachment.cgi?id=1445
>>> patch
>>>
>>> Export rtems_shell_init_env, rtems_shell_env_free, rtems_shell_main_mv,
>>> rtems_shell_main_cp and rtems_shell_main_rm
>>>
>> I think you changed these (at least the mv one) to be static recently.
>> Is this change acceptable?
>>
>>> --
>>> Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email
>>> ------- You are receiving this mail because: -------
>>> You are watching all bug changes.
>>> _______________________________________________
>>> rtems-bugs mailing list
>>> rtems-bugs at rtems.org
>>> http://rtems.org/mailman/listinfo/rtems-bugs
>>
>> _______________________________________________
>> rtems-devel mailing list
>> rtems-devel at rtems.org
>> http://www.rtems.org/mailman/listinfo/rtems-devel
>
> _______________________________________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-devel