[PATCH 2/3] score: New structure TOD_Control

[Sebastian Huber]

On 06/13/2012 02:32 PM, Joel Sherrill wrote:
> That's the method. Is it used? Is it correct to return an address?

Yes, this method is used.  Sorry, I don't understand what you mean with "return 
an address"?  The change is from "&_TOD_Now" to "&_TOD.now".

>
> Also you removed the "at tick" method. Did you restrict the math to using timestamp methods?

Yes, this uses only timestamp methods.

> You cannot assume 64 bit integers on all platforms. We are pretty sure they are always better on 32 bit CPUs but haven't analyzed 16 bit ones.

It is possible to make patch 3 conditional to int64 timestamps, but we should 
keep this tiny overhead for struct timespec targets to reduce the code complexity.

>
> Sebastian Huber<sebastian.huber at embedded-brains.de>  wrote:
>
>> >On 06/13/2012 01:52 PM, Joel Sherrill wrote:
>>> >>  _Timestamp_Get_seconds_since_epoch() returns an address. Is this correct based on its usage? Is it used?
>> >
>> >There is no such function.  Do you mean:
>> >
>> >#define _TOD_Seconds_since_epoch() \
>> >     _Timestamp_Get_seconds(&_TOD.now)


-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.