[rtems commit] psxtmtests - Eliminate missing prototype warnings

Sebastian Huber sebastian.huber at embedded-brains.de
Mon May 14 13:58:24 UTC 2012

On 05/14/2012 03:50 PM, Joel Sherrill wrote:
> On 05/13/2012 04:04 AM, Sebastian Huber wrote:
>> Why didn't you make the init functions static?
> Just didn't. They have always been global.

Why?  Who is supposed to call this function?

> Also I wasn't making value judgements on the code.
> I was just providing prototypes.
> FWIW While about 75% through the testsuites, I had the insight
> that this is actually a warning of questionable quality. Each
> of the ones I fixed was a case where the method
> was defined above the point of its use in the code.
> This warning was turned on without discussion and without
> any commitment to address warnings it generated.
> Some warnings do point out questionable code. This
> one just seems to be uselessly pedantic and addressing
> the things it points out does nothing IMO to improve
> code quality. It just means we can compile with one
> more warning enabled.

This warning is quite useful since it marks global functions without a proper 
header file.  Placing global function prototypes in a source file is a severe 
error from my point of view.

Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

More information about the devel mailing list