[rtems commit] psxtmtests - Eliminate missing prototype warnings

[Sebastian Huber]

On 05/14/2012 04:08 PM, Joel Sherrill wrote:
> Turning on a warning without discussing its value, how to
> address what it points out and a commitment to resolve
> them is bad IMO.

Yes.

>
> Our discussion points out that this warning was put in
> without that.

I didn't turn it on.

> We can always make a separate pass and move my
> prototypes to a .h file.  I really don't care about the
> solution. I do care about the process of evaluating
> warnings, turning them on, a plan to fix them and
> a commitment to do so.

A proper fix for this warning is either
	1. to add and use a header file with the prototype, or
	2. to make the function static.

A construct like (e.g. foo.c)

void bar(void);

void bar(void) {}

makes no sense.

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.