[PATCH 2/2] Initial bsp for Tiny6410

[Sebastian Huber]

Hello Peng Fan,

thanks for your new BSP.  I have some comments.

On 04/17/2013 07:27 AM, Peng Fan wrote:
> diff --git a/c/src/lib/libbsp/arm/shared/startup/linkcmds.armv6 b/c/src/lib/libbsp/arm/shared/startup/linkcmds.armv6
> new file mode 100644
> index 0000000..16fa3ef
> --- /dev/null
> +++ b/c/src/lib/libbsp/arm/shared/startup/linkcmds.armv6
> @@ -0,0 +1,26 @@
> +/**
> + * @file
> + *
> + * @ingroup bsp_linker
> + *
> + * @brief Linker command file for ARMv6 architecture.
> + */
> +
> +/*
> + * Copyright (c) 2010 embedded brains GmbH.  All rights reserved.
> + *
> + *  embedded brains GmbH
> + *  Obere Lagerstr. 30
> + *  82178 Puchheim
> + *  Germany
> + *<rtems at embedded-brains.de>
> + *
> + * The license and distribution terms for this file may be
> + * found in the file LICENSE in this distribution or at
> + *http://www.rtems.com/license/LICENSE.
> + */
> +
> +bsp_stack_svc_size = DEFINED (bsp_stack_svc_size) ? bsp_stack_svc_size : 4096;
> +bsp_stack_svc_size = ALIGN (bsp_stack_svc_size, bsp_stack_align);
> +
> +INCLUDE linkcmds.base

I think this file is superfluous and you should use the linkcmds.armv4 in your 
BSP.  If the SVC stack size is too small for your BSP, then change it in the 
BSP specific linker command file.

Please make sure that all files have a copyright and license header.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.