[PATCH 2/2] Initial bsp for Tiny6410

[Peng Fan]

Hi Sebastian,

Thanks for your reviewing the patch.
I'll modify the code and add the copyright related header.
Because s3c6410 is based on armv6 architecture, I create the linkcmds. I'll
move the size stack setting to linkcmds.armv4.Thanks again.

Regards,
Peng.


2013/4/17 Sebastian Huber <sebastian.huber at embedded-brains.de>

> Hello Peng Fan,
>
> thanks for your new BSP.  I have some comments.
>
>
> On 04/17/2013 07:27 AM, Peng Fan wrote:
>
>> diff --git a/c/src/lib/libbsp/arm/shared/**startup/linkcmds.armv6
>> b/c/src/lib/libbsp/arm/shared/**startup/linkcmds.armv6
>> new file mode 100644
>> index 0000000..16fa3ef
>> --- /dev/null
>> +++ b/c/src/lib/libbsp/arm/shared/**startup/linkcmds.armv6
>> @@ -0,0 +1,26 @@
>> +/**
>> + * @file
>> + *
>> + * @ingroup bsp_linker
>> + *
>> + * @brief Linker command file for ARMv6 architecture.
>> + */
>> +
>> +/*
>> + * Copyright (c) 2010 embedded brains GmbH.  All rights reserved.
>> + *
>> + *  embedded brains GmbH
>> + *  Obere Lagerstr. 30
>> + *  82178 Puchheim
>> + *  Germany
>> + *<rtems at embedded-brains.de>
>> + *
>> + * The license and distribution terms for this file may be
>> + * found in the file LICENSE in this distribution or at
>> + *http://www.rtems.com/license/**LICENSE<http://www.rtems.com/license/LICENSE>
>> .
>>
>> + */
>> +
>> +bsp_stack_svc_size = DEFINED (bsp_stack_svc_size) ? bsp_stack_svc_size :
>> 4096;
>> +bsp_stack_svc_size = ALIGN (bsp_stack_svc_size, bsp_stack_align);
>> +
>> +INCLUDE linkcmds.base
>>
>
> I think this file is superfluous and you should use the linkcmds.armv4 in
> your BSP.  If the SVC stack size is too small for your BSP, then change it
> in the BSP specific linker command file.
>
> Please make sure that all files have a copyright and license header.
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-**brains.de<sebastian.huber at embedded-brains.de>
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
> ______________________________**_________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/**listinfo/rtems-devel<http://www.rtems.org/mailman/listinfo/rtems-devel>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130417/b531994d/attachment-0001.html>