[PATCH 3/3] i386/virtualpok BSP, virtual BSP to be used with POK, build with enable-paravirt

Gedare Bloom gedare at rtems.org
Tue Dec 3 20:28:32 UTC 2013


Also if you find the time, we're starting an effort to add Doxygen
comments to our BSPs. You can see some notes on the process at
http://www.rtems.org/wiki/index.php/GoogleCodeInProjects#Structuring_Doxygen_in_libbsp
and if you can add Doxygen comments to your BSP that might be helpful.
Right now the best example we have is the lpc32xx in libbsp/arm. The
patch that added doxygen to it is at
http://git.rtems.org/rtems/commit/?id=2d6543d4c84cc896b7ff357772ea02472d49d882

On Tue, Dec 3, 2013 at 11:49 AM, Gedare Bloom <gedare at rtems.org> wrote:
> On Sat, Nov 30, 2013 at 4:13 AM, Philipp Eppelt
> <philipp.eppelt at mailbox.tu-dresden.de> wrote:
>> ---
>>  c/src/lib/libbsp/i386/acinclude.m4                 |   2 +
>>  c/src/lib/libbsp/i386/virtualpok/Makefile.am       |  87 ++++++++
>>  c/src/lib/libbsp/i386/virtualpok/README.virt       |  15 ++
>>  c/src/lib/libbsp/i386/virtualpok/bsp_specs         |  14 ++
>>  c/src/lib/libbsp/i386/virtualpok/clock/ckinit.c    | 139 ++++++++++++
>>  c/src/lib/libbsp/i386/virtualpok/configure.ac      |  23 ++
>>  c/src/lib/libbsp/i386/virtualpok/console/console.c | 184 ++++++++++++++++
>>  c/src/lib/libbsp/i386/virtualpok/include/bsp.h     |  53 +++++
>>  .../virtualpok/include/virtualizationlayerbsp.h    |  58 +++++
>>  c/src/lib/libbsp/i386/virtualpok/irq/irq.c         |  85 +++++++
>>  c/src/lib/libbsp/i386/virtualpok/irq/irq.h         |  79 +++++++
>>  c/src/lib/libbsp/i386/virtualpok/libpart.a         | Bin 0 -> 130636 bytes
>>  .../i386/virtualpok/make/custom/virtualpok.cfg     |  17 ++
>>  c/src/lib/libbsp/i386/virtualpok/preinstall.am     |  79 +++++++
>>  c/src/lib/libbsp/i386/virtualpok/start/_start.S    |  37 ++++
>>  .../libbsp/i386/virtualpok/start/bspgetworkarea.c  | 102 +++++++++
>>  .../lib/libbsp/i386/virtualpok/startup/bspstart.c  |  41 ++++
>>  c/src/lib/libbsp/i386/virtualpok/startup/linkcmds  | 244 +++++++++++++++++++++
>>  18 files changed, 1259 insertions(+)
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/Makefile.am
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/README.virt
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/bsp_specs
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/clock/ckinit.c
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/configure.ac
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/console/console.c
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/include/bsp.h
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/include/virtualizationlayerbsp.h
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/irq/irq.c
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/irq/irq.h
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/libpart.a
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/make/custom/virtualpok.cfg
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/preinstall.am
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/start/_start.S
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/start/bspgetworkarea.c
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/startup/bspstart.c
>>  create mode 100644 c/src/lib/libbsp/i386/virtualpok/startup/linkcmds
>>
> <patch snipped>
> Four comments.
>
> 1) I think libpart.a should not be included?
> 2) can the linkcmds be shared between virtualpok and pc386?
> 3) remane _start.S to be start.S
> 4) move bspgetworkarea.c to startup/ instead of start/.
>
> -Gedare



More information about the devel mailing list