[rtems commit] sptests: add a test for page size

Joel Sherrill Joel.Sherrill at OARcorp.com
Fri Dec 6 16:36:43 UTC 2013


On Dec 6, 2013 10:25 AM, Gedare Bloom <gedare at rtems.org> wrote:
>
> On Fri, Dec 6, 2013 at 10:55 AM, Joel Sherrill
> <Joel.Sherrill at oarcorp.com> wrote:
> > Reviewing from my cell phone so didn't compile.
> >
> > Copyright year is wrong.
> Fixed.
>
> > Does sysconf() need to be called to ensure it gives a consistent answer?
> sysconf() could be tested in a new psxtest if this is desired. By eye
> we can see it just uses PAGE_SIZE.

I think there is a sysconf test just was adding the idea a paranoid consistency check.

> >
> > Otherwise ok
> >
> > On Dec 6, 2013 9:46 AM, Gedare Bloom <gedare at rtems.org> wrote:
> > Module:    rtems
> > Branch:    master
> > Commit:    54da1243eb1840a7311e2449e3fb3c00d45c7f2f
> > Changeset:
> > http://git.rtems.org/rtems/commit/?id=54da1243eb1840a7311e2449e3fb3c00d45c7f2f
> >
> > Author:    Chirayu Desai <cdesai at cyanogenmod.org>
> > Date:      Fri Dec  6 20:53:36 2013 +0530
> >
> > sptests: add a test for page size
> >
> > Bug: https://www.rtems.org/bugzilla/show_bug.cgi?id=1216
> >
> > ---
> >
> >  testsuites/sptests/Makefile.am               |    4 +-
> >  testsuites/sptests/configure.ac              |    1 +
> >  testsuites/sptests/sppagesize/Makefile.am    |   22 ++++++++++++
> >  testsuites/sptests/sppagesize/init.c         |   45
> > ++++++++++++++++++++++++++
> >  testsuites/sptests/sppagesize/sppagesize.doc |   17 ++++++++++
> >  testsuites/sptests/sppagesize/sppagesize.scn |    2 +
> >  6 files changed, 89 insertions(+), 2 deletions(-)
> >
> > diff --git a/testsuites/sptests/Makefile.am b/testsuites/sptests/Makefile.am
> > index 4618d36..f440b0f 100644
> > --- a/testsuites/sptests/Makefile.am
> > +++ b/testsuites/sptests/Makefile.am
> > @@ -26,8 +26,8 @@ SUBDIRS = \
> >      spintrcritical09 spintrcritical10 spintrcritical11 spintrcritical12 \
> >      spintrcritical13 spintrcritical14 spintrcritical15 spintrcritical16 \
> >      spintrcritical17 spintrcritical18 spmkdir spmountmgr01 spheapprot \
> > -    spsem01 spsem02 spsimplesched01 spsimplesched02 spsimplesched03
> > spnsext01 \
> > -    spedfsched01 spedfsched02 spedfsched03 \
> > +    sppagesize spsem01 spsem02 spsimplesched01 spsimplesched02 \
> > +    spsimplesched03 spnsext01 spedfsched01 spedfsched02 spedfsched03 \
> >      spcbssched01 spcbssched02 spcbssched03 spqreslib sptimespec01
> >  SUBDIRS += spintrcritical20
> >  SUBDIRS += spintrcritical19
> > diff --git a/testsuites/sptests/configure.ac
> > b/testsuites/sptests/configure.ac
> > index 70e425d..69c999a 100644
> > --- a/testsuites/sptests/configure.ac
> > +++ b/testsuites/sptests/configure.ac
> > @@ -180,6 +180,7 @@ spmountmgr01/Makefile
> >  spnotepad01/Makefile
> >  spnsext01/Makefile
> >  spobjgetnext/Makefile
> > +sppagesize/Makefile
> >  spprintk/Makefile
> >  spprivenv01/Makefile
> >  spqreslib/Makefile
> > diff --git a/testsuites/sptests/sppagesize/Makefile.am
> > b/testsuites/sptests/sppagesize/Makefile.am
> > new file mode 100644
> > index 0000000..83647ef
> > --- /dev/null
> > +++ b/testsuites/sptests/sppagesize/Makefile.am
> > @@ -0,0 +1,22 @@
> > +
> > +rtems_tests_PROGRAMS = sppagesize
> > +sppagesize_SOURCES = init.c
> > +
> > +dist_rtems_tests_DATA = sppagesize.scn
> > +dist_rtems_tests_DATA += sppagesize.doc
> > +
> > +include $(RTEMS_ROOT)/make/custom/@RTEMS_BSP at .cfg
> > +include $(top_srcdir)/../automake/compile.am
> > +include $(top_srcdir)/../automake/leaf.am
> > +
> > +
> > +AM_CPPFLAGS += -I$(top_srcdir)/../support/include
> > +
> > +LINK_OBJS = $(sppagesize_OBJECTS)
> > +LINK_LIBS = $(sppagesize_LDLIBS)
> > +
> > +sppagesize$(EXEEXT): $(sppagesize_OBJECTS) $(sppagesize_DEPENDENCIES)
> > +       @rm -f sppagesize$(EXEEXT)
> > +       $(make-exe)
> > +
> > +include $(top_srcdir)/../automake/local.am
> > diff --git a/testsuites/sptests/sppagesize/init.c
> > b/testsuites/sptests/sppagesize/init.c
> > new file mode 100644
> > index 0000000..0f21aa8
> > --- /dev/null
> > +++ b/testsuites/sptests/sppagesize/init.c
> > @@ -0,0 +1,45 @@
> > +/*
> > + *  COPYRIGHT (c) 1989-2011.
> > + *  On-Line Applications Research Corporation (OAR).
> > + *
> > + *  The license and distribution terms for this file may be
> > + *  found in the file LICENSE in this distribution or at
> > + *  http://www.rtems.com/license/LICENSE.
> > + */
> > +
> > +#ifdef HAVE_CONFIG_H
> > +#include "config.h"
> > +#endif
> > +
> > +#include <tmacros.h>
> > +#include <rtems.h>
> > +#include <limits.h>
> > +#include <sys/param.h>
> > +
> > +/* forward declarations to avoid warnings */
> > +rtems_task Init(rtems_task_argument argument);
> > +
> > +rtems_task Init(
> > +  rtems_task_argument argument
> > +)
> > +{
> > +    puts("\n\n*** TEST SPPAGESIZE ***");
> > +
> > +    rtems_test_assert(PAGESIZE == PAGE_SIZE);
> > +    rtems_test_assert(getpagesize() == PAGE_SIZE);
> > +
> > +    puts("*** END OF TEST SPPAGESIZE ***");
> > +
> > +    rtems_test_exit(0);
> > +}
> > +
> > +#define CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER
> > +#define CONFIGURE_APPLICATION_DOES_NOT_NEED_CLOCK_DRIVER
> > +
> > +#define CONFIGURE_MAXIMUM_TASKS 1
> > +
> > +#define CONFIGURE_RTEMS_INIT_TASKS_TABLE
> > +
> > +#define CONFIGURE_INIT
> > +
> > +#include <rtems/confdefs.h>
> > diff --git a/testsuites/sptests/sppagesize/sppagesize.doc
> > b/testsuites/sptests/sppagesize/sppagesize.doc
> > new file mode 100644
> > index 0000000..696d1fa
> > --- /dev/null
> > +++ b/testsuites/sptests/sppagesize/sppagesize.doc
> > @@ -0,0 +1,17 @@
> > +#  COPYRIGHT (c) 1989-2011.
> > +#  On-Line Applications Research Corporation (OAR).
> > +#
> > +#  The license and distribution terms for this file may be
> > +#  found in the file LICENSE in this distribution or at
> > +#  http://www.rtems.com/license/LICENSE.
> > +#
> > +
> > +test name:  sppagesize
> > +
> > +directives:
> > +  getpagesize
> > +
> > +concepts:
> > +
> > ++ Verifies that the different declarations of pagesize have
> > +  the same value
> > diff --git a/testsuites/sptests/sppagesize/sppagesize.scn
> > b/testsuites/sptests/sppagesize/sppagesize.scn
> > new file mode 100644
> > index 0000000..2468e04
> > --- /dev/null
> > +++ b/testsuites/sptests/sppagesize/sppagesize.scn
> > @@ -0,0 +1,2 @@
> > +*** TEST SPPAGESIZE ***
> > +*** END OF TEST SPPAGESIZE ***
> >
> > _______________________________________________
> > rtems-vc mailing list
> > rtems-vc at rtems.org
> > http://www.rtems.org/mailman/listinfo/rtems-vc
> >
> > _______________________________________________
> > rtems-devel mailing list
> > rtems-devel at rtems.org
> > http://www.rtems.org/mailman/listinfo/rtems-devel
> >
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20131206/4109eef4/attachment-0001.html>


More information about the devel mailing list