[PATCH] libblock: Do resource allocation in one place

Chris Johns chrisj at rtems.org
Thu Feb 21 09:22:00 UTC 2013


Sebastian Huber wrote:
> On 02/21/2013 10:09 AM, Chris Johns wrote:
>> Sebastian Huber wrote:
>>> On 02/21/2013 03:56 AM, Chris Johns wrote:
>>>> Sebastian Huber wrote:
>>> If we allocate
>>> all resources in rtems_bdbuf_init() we have consistent behaviour.
>>
>> What determines "consistent behavior" ? Creating the tasks or letting
>> them run
>> to a blocking point ? This adds an interesting constraint to using the
>> cache.
>
> We have consistent behaviour if after rtems_bdbuf_init() no fatal errors
> can happen due to configuration errors or resources limits. This makes
> it easier to detect configuration errors for users. If
> rtems_bdbuf_init() fails, then we have a configuration problem and this
> is immediately obvious. If we have some time later during the system
> startup a fatal error in a worker task, then it is more difficult to
> deduce the error reason.

Good point. Ok to commit.

Chris



More information about the devel mailing list