[Patch] Removing legacy method from arm csb337

[Sebastian Huber]

Hello,

if you encounter a warning and you don't know how to get rid of it, then 
don't ignore it.  You can for example ask on the mailing list how to 
deal with it.  Before this ask a search engine.

On 05/07/13 18:58, Sebastian Huber wrote:
> gmake[6]: Entering directory 
> `/home/sh/git-build/b-csb337/arm-rtems4.11/c/csb337/lib/libbsp/arm/csb337'
> arm-rtems4.11-gcc --pipe -B../../../../../.././lib/ 
> -B../../../../../.././csb337/lib/ -specs bsp_specs -qrtems 
> -DHAVE_CONFIG_H   -isystem ../../../../../.././csb337/lib/include 
> -D__INSIDE_RTEMS_BSD_TCPIP_STACK__   -mstructure-size-boundary=8 
> -mcpu=arm920 -mfpu=vfp -mfloat-abi=soft -O2 -g  -Wall 
> -Wmissing-prototypes -Wimplicit-function-declaration 
> -Wstrict-prototypes -Wnested-externs -MT network_rel-network.o -MD -MP 
> -MF .deps/network_rel-network.Tpo -c -o network_rel-network.o `test -f 
> 'network/network.c' || echo 
> '/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/'`network/network.c
> /home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:87:1: warning: 
> function declaration isn't a prototype [-Wstrict-prototypes]
>  static void at91rm9200_emac_isr_on();
>  ^

This is the first hit with Google:

http://stackoverflow.com/questions/42125/function-declaration-isnt-a-prototype

[...]
>  ^
> /home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:207:10: 
> warning: no previous prototype for 'phyread' [-Wmissing-prototypes]
>  uint32_t phyread(uint8_t reg)
>           ^
> /home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:232:6: 
> warning: no previous prototype for 'phywrite' [-Wmissing-prototypes]
>  void phywrite(uint8_t reg, uint16_t data)

Here we have global functions without a prototype in a header file. This 
is very bad.  In case you see this, then search if this function is used 
in other places. If yes, then ask on the mailing list.  If no, then make 
it static.

[...]

> /home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:784:13: 
> warning: 'at91rm9200_emac_isr_off' defined but not used 
> [-Wunused-function]
>  static void at91rm9200_emac_isr_off()
>              ^
> /home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:795:12: 
> warning: 'at91rm9200_emac_isr_is_on' defined but not used 
> [-Wunused-function]
>  static int at91rm9200_emac_isr_is_on() 

In case you get this warning, then you have to determine if it is really 
unused.  If yes, then delete this function (and its prototype).  If no, 
then use it.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.