[PATCH] Updated Legacy code in arm rtl22xx

[Vipul Nayyar]

Hello,

Frankly speaking, I agree & tend to disagree at the same time.

	*  I agree that cs8900_isr() should be a static function, as it should not be accessed outside this file.
	* The declarations for global functions should not be present in source file, because their prototypes should be present in a header file.

I don't understand, why cs8900_isr() cannot be made to pass  cs8900_device *cs like I did in my patch. From where is this function is called ?

Regards
Vipul Nayyar 



________________________________
 From: Sebastian Huber <sebastian.huber at embedded-brains.de>
To: Vipul Nayyar <nayyar_vipul at yahoo.com> 
Cc: "rtems-devel at rtems.org" <rtems-devel at rtems.org> 
Sent: Friday, 12 July 2013 5:40 PM
Subject: Re: [PATCH] Updated Legacy code in arm rtl22xx
 

On 07/12/2013 02:01 PM, Vipul Nayyar wrote:
> You want this : (rtems_interrupt_handler)cs8900_isr ?

No, I want this

static void cs8900_isr(void *arg)
{
   cs8900_device *cs = arg;

   ...
}

Please remember that declarations of global functions in a source file are not 
acceptable.

Do you know why this is a problem?

>
> Plus, Do I need to put 0 instead of NULL ? I don't know right now if I'm aware
> of the answer or I'm just overlooking it .

How does the interrupt handler function cs8900_isr() get its argument value?

[...]

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130712/c81882b9/attachment-0001.html>