[PATCH] Updated Legacy code in arm rtl22xx

[Vipul Nayyar]

Hello,

I fail to see which part is superfluous, since the pointer cs is now used directly by the dispatch function to call the interrupt handler with parameter arg. The role of g_cs is completely removed.

Regards
Vipul Nayyar 



________________________________
 From: Sebastian Huber <sebastian.huber at embedded-brains.de>
To: Vipul Nayyar <nayyar_vipul at yahoo.com> 
Cc: "rtems-devel at rtems.org" <rtems-devel at rtems.org> 
Sent: Monday, 15 July 2013 1:57 PM
Subject: Re: [PATCH] Updated Legacy code in arm rtl22xx
 

On 07/13/2013 10:18 AM, Vipul Nayyar wrote:
> @@ -69,13 +63,26 @@ unsigned short cs8900_mem_get_reg (cs8900_device *cs,
> unsigned long reg)
>
> void cs8900_attach_interrupt (cs8900_device *cs)
> {
> -    g_cs = cs;
> -    BSP_install_rtems_irq_handler(&cs8900_isr_data);
> +    rtems_status_code status = RTEMS_SUCCESSFUL;
> +    status = rtems_interrupt_handler_install(
> +        LPC22xx_INTERRUPT_EINT2,
> +        "Network",
> +        RTEMS_INTERRUPT_UNIQUE,
> +        (rtems_interrupt_handler)cs8900_isr,

Since you fixed the cs8900_isr(), this case is now superfluous.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130715/39bbd112/attachment-0001.html>