[PATCH] Updated legacy code on arm gumstix

[Vipul Nayyar]

Hello,

BTW, Just wanted to clarify, that I always compile & check for warnings before submitting. In the case of gumstix, I've compiled it now again & earlier also when this thread was active. I haven't faced any errors or warnings related to the files that I edited. Just a couple of warnings in bspstart.c & abort.c . Rest warnings are from cpukit & libcpu.

../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/startup/bspstart.c:32:6: warning: no previous prototype for 'bsp_start_default' [-Wmissing-prototypes]
 void bsp_start_default( void )
      ^
../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/startup/bspstart.c:47:6: warning: no previous prototype for 'bsp_reset' [-Wmissing-prototypes]
 void bsp_reset( void )
      ^
../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/../shared/abort/abort.c:63:6: warning: no previous prototype for '_print_full_context' [-Wmissing-prototypes]
 void _print_full_context(uint32_t spsr)
      ^
../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/../shared/abort/abort.c:105:6: warning: no previous prototype for 'do_data_abort' [-Wmissing-prototypes]
 void do_data_abort(uint32_t   insn, uint32_t   spsr,
      ^
../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/../shared/abort/abort.c: In function 'do_data_abort':
../../../../../../../../rtems/c/src/lib/libbsp/arm/gumstix/../shared/abort/abort.c:111:27: warning: variable 'level' set but not used [-Wunused-but-set-variable]
     rtems_interrupt_level level;
                           ^

I really appreciate your efforts, in criticizing my patches & helping me improve them. 

Regards
Vipul Nayyar 



________________________________
 From: Sebastian Huber <sebastian.huber at embedded-brains.de>
To: rtems-devel at rtems.org 
Sent: Saturday, 13 July 2013 1:29 AM
Subject: Re: [PATCH] Updated legacy code on arm gumstix
 

I got this:

arm-rtems4.11-gcc --pipe -B../../../../../.././lib/ 
-B../../../../../.././gumstix/lib/ -specs bsp_specs -qrtems 
-DHAVE_CONFIG_H   -isystem ../../../../../.././gumstix/lib/include 
-D__INSIDE_RTEMS_BSD_TCPIP_STACK__   -mstructure-size-boundary=8 
-mcpu=xscale -mfpu=vfp -mfloat-abi=soft -O2 -g  -Wall 
-Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes 
-Wnested-externs -MT rtl8019_rel-rtl8019.o -MD -MP -MF 
.deps/rtl8019_rel-rtl8019.Tpo -c -o rtl8019_rel-rtl8019.o `test -f 
'rtl8019/rtl8019.c' || echo 
'/home/sh/rtems-4.11/c/src/lib/libbsp/arm/gumstix/'`rtl8019/rtl8019.c
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c: In 
function 'ne_init_irq_handler':
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c:486:5: warning: 
passing argument 4 of 'rtems_interrupt_handler_install' from 
incompatible pointer type [enabled by default]
      );
      ^
In file included from 
../../../../../.././gumstix/lib/include/bsp/irq.h:19:0,
                  from 
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c:12:
../../../../../.././gumstix/lib/include/rtems/irq-extension.h:114:19: 
note: expected 'rtems_interrupt_handler' but argument is of type 'void 
(*)(struct ne_softc *)'
  rtems_status_code rtems_interrupt_handler_install(

Didn't we agree, that you compile the code and eliminate all warnings?

http://git.rtems.org/rtems/commit/?id=163e88a8c36815dad65a0342a2d6f851f1f5ed9f

On 12/07/13 19:03, Vipul Nayyar wrote:
> ---
>   c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c | 15 ++++-----------
>   1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c b/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c
> index ef8ae4e..d419eac 100644
> --- a/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c
> +++ b/c/src/lib/libbsp/arm/gumstix/rtl8019/rtl8019.c
> @@ -332,10 +332,8 @@ ne_check_status (struct ne_softc *sc, int from_irq_handler)
>   /* Handle an NE2000 interrupt.  */
>  
>   static void
> -ne_interrupt_handler (rtems_irq_hdl_param handle)
> +ne_interrupt_handler (struct ne_softc *sc)
>   {
> -  struct ne_softc *sc = handle;
> -
>     if (sc == NULL)
>       return;
>  
> @@ -350,10 +348,8 @@ ne_interrupt_handler (rtems_irq_hdl_param handle)
>   /* Turn NE2000 interrupts on.  */
>  
>   static void
> -ne_interrupt_on (const void * handle)
> +ne_interrupt_on (struct ne_softc *sc)
>   {
> -  struct ne_softc *sc = handle;
> -
>   #ifdef DEBUG_NE
>     printk ("ne_interrupt_on()\n");
>   #endif
> @@ -364,10 +360,8 @@ ne_interrupt_on (const void * handle)
>   /* Turn NE2000 interrupts off.  See ne_interrupt_on.  */
>  
>   static void
> -ne_interrupt_off (const void * handle)
> +ne_interrupt_off (struct ne_softc *sc)
>   {
> -  struct ne_softc *sc = handle;
> -
>   #ifdef DEBUG_NE
>     printk ("ne_interrupt_off()\n");
>   #endif
> @@ -380,9 +374,8 @@ ne_interrupt_off (const void * handle)
>    *If it is eanbled, return 1
>   */
>   static int
> -ne_interrupt_is_on (const void * handle)
> +ne_interrupt_is_on (struct ne_softc *sc)
>   {
> -  struct ne_softc *sc = handle;
>     unsigned char imr;
>   #ifdef DEBUG_NE
>     printk("ne_interrupt_is_on()\n");


-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

_______________________________________________
rtems-devel mailing list
rtems-devel at rtems.org
http://www.rtems.org/mailman/listinfo/rtems-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130715/52a6a5b8/attachment-0001.html>