[Patch] Removing legacy method from arm csb336

[Joel Sherrill]

I agree with you Gedare. The legacy api support remains for a while. There is external code which could use it and we always hold legacy for at least one release branch.

I just want the code in the tree to use the new way consistently. And update check_submission to flag the old way

Gedare Bloom <gedare at rtems.org> wrote:


On Thu, Jun 27, 2013 at 4:46 AM, Joel Sherrill
<Joel.Sherrill at oarcorp.com> wrote:
> The goal of this is to kill bad examples. It is legacy and we don't want
> people to use it anymore. These should be mechanical changes. Vipul should
> be able to provide instructions for users with external drivers to make the
> changes.
>
> Fixing these could break here or there but if we don't remove uses of
> deprecated methods then users will use them in new BSPs and that is
> unacceptable.
>
I'd prefer to see 4.11 released before we start killing off legacy support.

> Vipul Nayyar <nayyar_vipul at yahoo.com> wrote:
>
> Hello,
>
> According to the discussions with my mentor Joel Sherill, I was suggested to
> kill all legacy/deprecated API uses in the tree which are defined in
> irq-legacy.c as part of my project. I guess Dr Joel can guide us better
> whether all of the deprecated methods need to be removed or only some of
> them. cc'ing Dr Joel for guidance on this.
>
> Regards
> Vipul Nayyar
>
>
> ________________________________
> From: Sebastian Huber <sebastian.huber at embedded-brains.de>
> To: rtems-devel at rtems.org
> Sent: Thursday, 27 June 2013 1:48 PM
> Subject: Re: [Patch] Removing legacy method from arm csb336
>
> On 06/26/2013 05:28 PM, Vipul Nayyar wrote:
>>
>> For my GSOC Project Unified APIs,  a public google doc has been setup (
>>
>> https://docs.google.com/document/d/1W9DMnpocXUKXiQMxHbbp0aG-ecuh94P-3N7hxEJmcgs/edit?usp=sharing)
>> for community viewing. In order to establish this unified pattern across
>> all
>> BSPs, I felt that deprecated methods stored in irq-legacy.c should be
>> dealt
>> with first. So, I'm attaching a very basic patch which removes the
>> deprecated
>> method BSP_install_rtems_irq_handler from arm csb336 and instead makes use
>> of rtems_interrupt_handler_install, as suggested in irq-legacy.c. Please
>> do
>> give suggestions if I'm heading the right way, and any modifications that
>> this
>> patch may require.
>
> I would not touch the existing code that uses these legacy functions.  The
> irq-legacy.c is provided to keep existing code as is.
>
> -- Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone  : +49 89 189 47 41-16
> Fax    : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP    : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
> _______________________________________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-devel
>
>
>
> _______________________________________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-devel
>