[PATCH] libchip/rtc: Fixed 19 compiler warnings

[Jennifer Averett]

Building for the sis... this looks like it is broken.  

icm7170_reg.c defines

void  _ICM7170_NAME(icm7170_set_register)(
  uintptr_t   ulCtrlPort,
  uint8_t     ucRegNum,
  uint32_t    ucData
)

icm7170.h

void  icm7170_set_register_2(
  uint32_t    ulCtrlPort,
  uint8_t     ucRegNum,
  uint32_t    ucData
);


Which one is correct?

Jennifer Averett
On-Line Applications Research
________________________________________
From: rtems-devel-bounces at rtems.org [rtems-devel-bounces at rtems.org] On Behalf Of Andreas Heinig [andreas.heinig at cs.tu-dortmund.de]
Sent: Thursday, February 28, 2013 11:08 AM
To: rtems-devel at rtems.org
Subject: [PATCH] libchip/rtc: Fixed 19 compiler warnings

---
 c/src/libchip/rtc/icm7170_reg.c |    2 ++
 c/src/libchip/rtc/m48t08_reg.c  |    2 ++
 c/src/libchip/rtc/mc146818a.c   |    6 +++---
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/c/src/libchip/rtc/icm7170_reg.c b/c/src/libchip/rtc/icm7170_reg.c
index 378dd7a..975b591 100644
--- a/c/src/libchip/rtc/icm7170_reg.c
+++ b/c/src/libchip/rtc/icm7170_reg.c
@@ -14,6 +14,8 @@
  */

 #include <rtems.h>
+#include <libchip/rtc.h>
+#include <libchip/icm7170.h>

 #ifndef _ICM7170_MULTIPLIER
 #define _ICM7170_MULTIPLIER 1
diff --git a/c/src/libchip/rtc/m48t08_reg.c b/c/src/libchip/rtc/m48t08_reg.c
index 42d45d7..828c03a 100644
--- a/c/src/libchip/rtc/m48t08_reg.c
+++ b/c/src/libchip/rtc/m48t08_reg.c
@@ -14,6 +14,8 @@
  */

 #include <rtems.h>
+#include <libchip/rtc.h>
+#include <libchip/m48t08.h>

 #ifndef _M48T08_MULTIPLIER
 #define _M48T08_MULTIPLIER 1
diff --git a/c/src/libchip/rtc/mc146818a.c b/c/src/libchip/rtc/mc146818a.c
index 4b8bf6a..1540d94 100644
--- a/c/src/libchip/rtc/mc146818a.c
+++ b/c/src/libchip/rtc/mc146818a.c
@@ -52,7 +52,7 @@ bool mc146818a_probe(
 /*
  * Initialize chip
  */
-void mc146818a_initialize(
+static void mc146818a_initialize(
   int minor
 )
 {
@@ -69,7 +69,7 @@ void mc146818a_initialize(
 /*
  * Read time from chip
  */
-int mc146818a_get_time(
+static int mc146818a_get_time(
   int                minor,
   rtems_time_of_day *time
 )
@@ -129,7 +129,7 @@ int mc146818a_get_time(
 /*
  * Set time into chip
  */
-int mc146818a_set_time(
+static int mc146818a_set_time(
   int                      minor,
   const rtems_time_of_day *time
 )
--
1.7.10.4

_______________________________________________
rtems-devel mailing list
rtems-devel at rtems.org
http://www.rtems.org/mailman/listinfo/rtems-devel