[PATCH 2/2] [cpukit/POSIX] Renamed POSIX signal functions to match style of the other POSIX related functions

[Gedare Bloom]

I'm inclined to accept the modification (on updated Git head), since
it is more consistent with the other internal posix managers.

The only other counterexample I could find in RTEMS was the handful of
_CORE_xxx definitions in supercore.
-Gedare

On Wed, Mar 20, 2013 at 2:43 AM, Andreas Heinig
<andreas.heinig at cs.tu-dortmund.de> wrote:
> On Tuesday 19 March 2013 09:21:35 Joel Sherrill wrote:
>> + Your tree is NOT up to date. It has ChangeLog files in it.
> True,
>> + You did a blind search and replace since it changed ChangeLog
>> entries before your change was made.
> That is correct. However, I accidentally added the ChangeLog to the patch
>
>> Now to see if I can understand what you were trying to
>> do specifically. Can you give a very simple summary with
>> details. Like "renamed X to Y". "Changed include from X to
>> Y after renaming file." etc.  The patch appears to be the
>> result of a global search and replace and it would be
>> easier to review if we knew what that was.
>
> Ok, simply speaking: I had found a warning in the file
> rtems/cpukit/sapi/src/posixapi.c. Here, the compiler complained about nested
> external definition of _POSIX_signals_Manager_Initialization in function
> _POSIX_API_Initialize.
>
> After fixing the warning and having a closer look on _POSIX_API_Initialize, I
> saw this:
>
>  64   _POSIX_signals_Manager_Initialization();
>              ^               ^
>  65   _POSIX_Threads_Manager_initialization();
>  66   _POSIX_Condition_variables_Manager_initialization();
>  67   _POSIX_Key_Manager_initialization();
>  68   _POSIX_Mutex_Manager_initialization();
>  69   _POSIX_Message_queue_Manager_initialization();
>  70   _POSIX_Semaphore_Manager_initialization();
>  71   _POSIX_Timer_Manager_initialization();
>  72   _POSIX_Barrier_Manager_initialization();
>  73   _POSIX_RWLock_Manager_initialization();
>  74   _POSIX_Spinlock_Manager_initialization();
>
> Compared to all the other initialization routines, the Signal Manager has
> different capitalization. Hence, I changed 's'ignals to 'S'ignals and
> 'I'nitialization to 'i'nitialization.
>
> And due to the fact that the whole POSIX signal subsystem uses the "wrong"
> prefix _POSIX_signals_, I have made a global search and replace to change it
> to _POSIX_Signals_.
>
> Here is the command:
> find . ! -path "*/.svn*" ! -path "*/.git*" -type f \
> -exec sed -e"s/_POSIX_signals/_POSIX_Signals/g" -i
>
> Regards,
> Andreas
>
>
> _______________________________________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-devel