[PATCH] Fixed typo in mpc5200_psc_isOn()

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Feb 7 10:32:07 UTC 2014


Hello Aleksandr,

this function is unused.  If you want to clean up this file, then you can 
replace the call to BSP_install_rtems_irq_handler() with 
rtems_interrupt_handler_install().  See also

http://git.rtems.org/rtems/commit/?id=893d66937a17c4bb9fb3b909cf884948b466a3b5

for an example.

Please send patches in the "git format-patch" format.

On 2014-02-05 14:55, Aleksandr Platonov wrote:
> Hi.
>
> In current code mpc5200_psc_isOn() function always return false.
> Patch should be the following:
>
> diff --git a/c/src/lib/libbsp/powerpc/gen5200/console/console.c
> b/c/src/lib/libbsp/powerpc/gen5200/console/console.c
> index a70e06d..5740b5b 100644
> --- a/c/src/lib/libbsp/powerpc/gen5200/console/console.c
> +++ b/c/src/lib/libbsp/powerpc/gen5200/console/console.c
> @@ -399,7 +399,7 @@ int mpc5200_psc_isOn(
>
>     if (minor >= 0) {
>       psc = (struct mpc5200_psc *)(&mpc5200.psc[psc_minor_to_regset[minor]]);
> -    return ((psc->isr_imr & IMR_RX_RDY_FULL) & (psc->isr_imr & IMR_TX_RDY));
> +    return ((psc->isr_imr & IMR_RX_RDY_FULL) && (psc->isr_imr & IMR_TX_RDY));
>     }
>     return false;
>   }
> _______________________________________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-devel


-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list