[rtems-testing] Patch to the merge-helper script

Martin Boretto martin.boretto at tallertechnologies.com
Wed Jun 4 21:21:18 UTC 2014


Hi everyone,

This patch fixes an issue.

When a needed function is not found it didn't show the warning but it still
put the faults variable to 1.

With this patch I propose to always see the warning and set the faults to
1. Also set an ending message saying when not everything went fine.




Martin Boretto
Software Engineer

Taller Technologies - Argentina
San Lorenzo 47, 3rd Floor, Office 5
Córdoba, Argentina

*Mobile:* [+54 358 4206995 (ARG)]
*Skype:* tinacho_b
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20140604/8217e317/attachment.html>
-------------- next part --------------
diff --git a/merge-helpers/check_submission b/merge-helpers/check_submission
index a934646..5444b1b 100755
--- a/merge-helpers/check_submission
+++ b/merge-helpers/check_submission
@@ -198,10 +198,8 @@ function check_methods(){
             echo $bsp : ${i%(*}"()" present in file $(grep -rlE "[a-z|A-Z|0-9|_]+[ ]*$i[ ]*\(" *)
            fi
         else
-          if [[ $warnings -eq "1" || $important -eq "1" || $verbose -eq "1" ]]; then
             echo "$bsp : $(basename $filename) : ${i%(*}() function does not exist in $filename "
             flag="1"
-          fi
             faults="1"
         fi
       fi
@@ -687,4 +685,6 @@ start "$@"
 # End of Checks
 if [[ $faults -eq "0" ]] ; then
   echo -e "\nNo faults found in BSP organization"
+else
+  echo -e "\nFound faults in BSP organization. Please, check"
 fi


More information about the devel mailing list