[PATCH 2/2] samples/fileio: Adaption for shell with posix keys.

[Sebastian Huber]

On 2014-03-19 16:59, Gedare Bloom wrote:
> On Wed, Mar 19, 2014 at 11:49 AM, Sebastian Huber
> <sebastian.huber at embedded-brains.de>  wrote:
>> >On 2014-03-19 16:33, Gedare Bloom wrote:
>>> >>
>>> >>On Wed, Mar 19, 2014 at 11:15 AM, Christian Mauderer
>>> >><christian.mauderer at embedded-brains.de>   wrote:
>>>> >>>
>>>>> >>> >From: Christian Mauderer<Christian.Mauderer at embedded-brains.de>
>>>>> >>> >
>>>>> >>> >Add necessary objects.
>>>>> >>> >Add login function and custom device name for better testing of the
>>>>> >>> >shell.
>>>>> >>> >---
>>>>> >>> >  testsuites/samples/fileio/init.c   | 5 +++--
>>>>> >>> >  testsuites/samples/fileio/system.h | 3 +++
>>>>> >>> >  2 files changed, 6 insertions(+), 2 deletions(-)
>>>>> >>> >
>>>>> >>> >diff --git a/testsuites/samples/fileio/init.c
>>>>> >>> >b/testsuites/samples/fileio/init.c
>>>>> >>> >index 80da4ab..2a0f9db 100644
>>>>> >>> >--- a/testsuites/samples/fileio/init.c
>>>>> >>> >+++ b/testsuites/samples/fileio/init.c
>>>>> >>> >@@ -708,10 +708,11 @@ static void fileio_start_shell(void)
>>>>> >>> >      "SHLL",                          /* task_name */
>>>>> >>> >      RTEMS_MINIMUM_STACK_SIZE * 4,    /* task_stacksize */
>>>>> >>> >      100,                             /* task_priority */
>>>>> >>> >-    "/dev/console",                  /* devname */
>>>>> >>> >+    "/dev/foobar",                   /* devname */
>>>>> >>> >+    /* device is currently ignored by the shell if it is not a pty */
>>>>> >>> >      false,                           /* forever */
>>>>> >>> >      true,                            /* wait */
>>>>> >>> >-    NULL                             /* login */
>>>>> >>> >+    rtems_shell_login_check          /* login */
>>>>> >>> >    );
>>>>> >>> >  }
>>>>> >>> >  #endif /* USE_SHELL */
>>>>> >>> >diff --git a/testsuites/samples/fileio/system.h
>>>>> >>> >b/testsuites/samples/fileio/system.h
>>>>> >>> >index 726a507..654f727 100644
>>>>> >>> >--- a/testsuites/samples/fileio/system.h
>>>>> >>> >+++ b/testsuites/samples/fileio/system.h
>>>>> >>> >@@ -47,6 +47,9 @@ rtems_task Init(
>>>>> >>> >  #define CONFIGURE_ATA_DRIVER_TASK_PRIORITY  14
>>>>> >>> >  #endif
>>>>> >>> >
>>>>> >>> >+#define CONFIGURE_MAXIMUM_POSIX_KEYS             1
>>>>> >>> >+#define CONFIGURE_MAXIMUM_POSIX_KEY_VALUE_PAIRS  1
>>>>> >>> >+
>>> >>
>>> >>Should this CONFIGURE_KEYS be dealt with at confdefs.h?
>>> >>
>> >
>> >This is the basic problem with the RTEMS configuration.  You have this
>> >problem with device drivers, C++, library functions etc.
>> >
>> >If you don't know how many objects you need, then use unlimited objects and
>> >a unified work space.
>> >
> Then the requirement for a posix key when using the shell must be
> captured in the documentation somewhere.
>

Yes, but I don't think adding support for everything to confdefs.h is the 
solution here.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.