[PATCH] [RSB] Add support for building rtems-or1k tool-chain.

[Chris Johns]

On 26/05/2014 11:06 am, Hesham Moustafa wrote:
>
> Great! Before submitting the next fixed patch, I would like you give a
> feedback regarding this change.
> 1- I have added a new "%define gdb-disable-sim 1" line to rtems-or1k.bset
> 2- Add
> "%{!?gdb-disable-sim:--enable-sim}%{?gdb-disable-sim:--disable-sim}" to
> gdb-7-1.cfg (the common gdb file)
>

This looks fine.

> Should gdb-disable-sim be defined (with 0 or 1) for all targets? or not
> defining it is OK (means that it's 0) ?

I would not define it in each target. The default is to enable the 
simulator. If you need to explicitly default it add a check earlier in 
the config file to detect if %gdb_disable_sim is define and if not add a 
define set to 0.

Chris