[PATCH 04/12] bsp/arm: Broadcast cache maintenances

Sebastian Huber sebastian.huber at embedded-brains.de
Wed May 28 13:07:15 UTC 2014


On 2014-05-27 16:52, Gedare Bloom wrote:
> On Tue, May 27, 2014 at 10:45 AM, Ralf Kirchner
> <ralf.kirchner at embedded-brains.de>  wrote:
>> >---
>> >  c/src/lib/libbsp/arm/shared/include/arm-a9mpcore-start.h |    2 +-
>> >  1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
>> >
>> >diff --git a/c/src/lib/libbsp/arm/shared/include/arm-a9mpcore-start.h b/c/src/lib/libbsp/arm/shared/include/arm-a9mpcore-start.h
>> >index 578c842..97977ba 100644
>> >--- a/c/src/lib/libbsp/arm/shared/include/arm-a9mpcore-start.h
>> >+++ b/c/src/lib/libbsp/arm/shared/include/arm-a9mpcore-start.h
>> >@@ -108,7 +108,7 @@ BSP_START_TEXT_SECTION static inline void arm_a9mpcore_start_hook_0(void)
>> >    /* Enable cache coherency support for this processor */
>> >    {
>> >      uint32_t actlr = arm_cp15_get_auxiliary_control();
>> >-    actlr |= ARM_CORTEX_A9_ACTL_SMP;
>> >+    actlr |= ARM_CORTEX_A9_ACTL_SMP | ARM_CORTEX_A9_ACTL_FW;
> Perhaps this should be encapsulated by a function call, considering it
> is copied in some other start hooks?
>

The real problem is that this code is copied at all.  We have to clean this up.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list