[PATCH 2/2] nfs: Add RPCd task affinity config option

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Nov 13 09:23:49 UTC 2014


On 13/11/14 10:09, Daniel Cederman wrote:
> @@ -407,6 +410,8 @@ static rtems_interval	ticksPerSec;		/* cached system clock rate (WHO IS ASSUMED
>   											 */
>
>   rtems_task_priority		rpciodPriority = 0;
> +cpu_set_t            *rpciodCpuset = 0;
> +size_t                rpciodCpusetSize = 0;
>
>   #if (DEBUG) & DEBUG_MALLOC
>   /* malloc wrappers for debugging */

Missing #ifdef RTEMS_SMP ?

I am not sure if we should really use #ifdef RTEMS_SMP for the #include 
<sys/cpuset.h>.  We use also #if defined(__RTEMS_HAVE_SYS_CPUSET_H__) && 
defined(RTEMS_SMP) sometimes.  I would simply force users to update their 
Newlib version.

Please fix the spacing and use the coding style of the file.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list